Skip to content

Comments

fix: check test error state#1594

Merged
g3john merged 2 commits intomainfrom
fix/check-test-error-state
Feb 20, 2026
Merged

fix: check test error state#1594
g3john merged 2 commits intomainfrom
fix/check-test-error-state

Conversation

@g3john
Copy link
Contributor

@g3john g3john commented Feb 17, 2026

What this PR does / why we need it

Context

  • [Switches from Script to Execution when it shouldn't]: Fix race condition in useFormNavigationState where errors state lagged formErrors by one render cycle
  • [Doesn't switch from Execution to Script when it should]: Fix BROWSER_CHECK_FIELDS registering 'instance' instead of 'target', causing the target field to be unhandled by sectionByErrors on Browser checks.
Screen.Recording.2026-02-18.at.9.59.39.AM.mov

@github-actions github-actions bot added the fix A fix applied to the application. label Feb 17, 2026
@github-actions
Copy link

github-actions bot commented Feb 17, 2026

Script size changes

Name +/- Main This PR Outcome
[217.js] = 2,190.00 kB 2,190.00 kB
[361.js] = 801.07 kB 801.08 kB
[datasource/module.js] = 25.25 kB 25.25 kB
[692.js] = 20.64 kB 20.64 kB
[663.js] = 5.83 kB 5.83 kB
[module.js] = 4.59 kB 4.59 kB
[156.js] = 1.90 kB 1.90 kB

Totals

Name +/- Main This PR Outcome
[Scripts] = 3,049.27 kB 3,049.29 kB
[Non-script Assets] = 2,679.89 kB 2,679.89 kB
[All] = 5,729.16 kB 5,729.18 kB

Generated by 🚫 dangerJS against 4e8c6f3

@g3john g3john marked this pull request as ready for review February 17, 2026 22:55
@g3john g3john requested a review from a team as a code owner February 17, 2026 22:55
@g3john g3john requested review from VikaCep and ckbedwell and removed request for a team February 17, 2026 22:55
@ckbedwell
Copy link
Contributor

Great job! Can we update it so that the test button engages the validation in the stepper too like it does with the save button and manual navigation?

image

@g3john g3john closed this Feb 18, 2026
@g3john g3john reopened this Feb 18, 2026
@github-actions
Copy link

TruffleHog Scan Results

No secrets detected in this PR.

@g3john
Copy link
Contributor Author

g3john commented Feb 18, 2026

Great job! Can we update it so that the test button engages the validation in the stepper too like it does with the save button and manual navigation?

image

Updated the PR description video with the change

Copy link
Contributor

@VikaCep VikaCep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

Copy link
Contributor

@ckbedwell ckbedwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏

@g3john g3john merged commit 9a118c0 into main Feb 20, 2026
54 of 61 checks passed
@g3john g3john deleted the fix/check-test-error-state branch February 20, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix A fix applied to the application.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants