Skip to content

Comments

chore: cleanup constant naming convention#1596

Merged
g3john merged 3 commits intomainfrom
chore/cleanup-constant-naming-convention
Feb 19, 2026
Merged

chore: cleanup constant naming convention#1596
g3john merged 3 commits intomainfrom
chore/cleanup-constant-naming-convention

Conversation

@g3john
Copy link
Contributor

@g3john g3john commented Feb 18, 2026

Summary

Constants have inconsistent naming conventions

Addresses #1008

Changes

  • Changes constants names and keys to follow SCREAMING_SNAKE_CASE

@github-actions github-actions bot added the chore A miscellaneous change added to the application. label Feb 18, 2026
@github-actions
Copy link

github-actions bot commented Feb 18, 2026

Probe API Server Mappings Verification Passed

The probeAPIServerMappings.json file is up to date and matches the Grafana documentation. 🎉

@github-actions
Copy link

github-actions bot commented Feb 18, 2026

Script size changes

Name +/- Main This PR Outcome
[217.js] = 2,190.00 kB 2,190.00 kB
[361.js] +0.02% 801.07 kB 801.24 kB
[datasource/module.js] = 25.25 kB 25.25 kB
[692.js] = 20.64 kB 20.64 kB
[663.js] = 5.83 kB 5.83 kB
[module.js] = 4.59 kB 4.59 kB
[156.js] = 1.90 kB 1.90 kB

Totals

Name +/- Main This PR Outcome
[Scripts] = 3,049.27 kB 3,049.45 kB
[Non-script Assets] = 2,679.89 kB 2,680.09 kB
[All] = 5,729.16 kB 5,729.53 kB

Generated by 🚫 dangerJS against 992eadc

@github-actions
Copy link

github-actions bot commented Feb 18, 2026

TruffleHog Scan Results

Summary: Found 1 potential secrets (0 verified, 1 unverified)

  • Possible secret (PrivateKey) at src/test/fixtures/checks.ts:1----***---

Review: Check if unverified secrets are false positives.

Comment on lines +44 to +49
{
"region": "Europe",
"provider": "AWS",
"apiServerURL": "synthetic-monitoring-grpc-eu-west-6.grafana.net:443",
"backendAddress": "synthetic-monitoring-api-eu-west-6.grafana.net"
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Satisfies #1596 (comment)

@g3john g3john marked this pull request as ready for review February 18, 2026 22:21
@g3john g3john requested a review from a team as a code owner February 18, 2026 22:21
@g3john g3john requested review from VikaCep and removed request for a team February 18, 2026 22:21
Copy link
Contributor

@VikaCep VikaCep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ⭐ ⭐

@g3john g3john merged commit 0e1fa9b into main Feb 19, 2026
37 checks passed
@g3john g3john deleted the chore/cleanup-constant-naming-convention branch February 19, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A miscellaneous change added to the application.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants