Extend schema to allow for presigned URLs for uploading files#108
Open
singingwolfboy wants to merge 13 commits intographile:mainfrom
singingwolfboy:upload-via-signed-url-extend-schema
Open
Extend schema to allow for presigned URLs for uploading files#108singingwolfboy wants to merge 13 commits intographile:mainfrom singingwolfboy:upload-via-signed-url-extend-schema
singingwolfboy wants to merge 13 commits intographile:mainfrom
singingwolfboy:upload-via-signed-url-extend-schema
Conversation
benjie
requested changes
Feb 24, 2020
Member
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
A few comments, sorry about the delay - I've been busy on other projects.
Member
|
CI is failing because |
benjie
requested changes
Apr 20, 2020
Member
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
Thanks for improving this PR 👍 I've left some more feedback.
This was referenced May 15, 2020
Draft
Member
|
I tried to get this into a mergeable state in #167 but I ran out of time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #107. This extends our GraphQL schema to expose a
createUploadUrlmutation, which allows an API client to get a pre-signed URL for uploading a file to S3.