Allow setting cookies from other origins#197
Open
justinr1234 wants to merge 1 commit intographile:mainfrom
Open
Allow setting cookies from other origins#197justinr1234 wants to merge 1 commit intographile:mainfrom
justinr1234 wants to merge 1 commit intographile:mainfrom
Conversation
benjie
requested changes
Sep 2, 2020
| ) || []) | ||
| ); | ||
| } | ||
| if (req.isSameOrigin || origins.includes(req.get("Origin") || "")) { |
Member
There was a problem hiding this comment.
I think we should rename isSameOrigin to isAllowedOrigin and move this logic there.
Also, please process environmental variables in the root scope, near the top of the file, rather than within the middleware itself. At the moment this replace/split has to be executed for every single request which is an unnecessary cost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows cookies to be sent from an origin other than the primary origin. This can be useful if you want to have multiple sites hosted from different sub-domains but using the same API. Additionally, in development mode, this allows you to use a separate server (such as Ionic dev server) to go against the same API.
There shouldn't be any security concerns as this by default uses the same origin. It only allows changes if you specifically want to whitelist a particular domain to allow cookies from there.
Pass in allowed values as a comma-separated string:
SESSION_ALLOWED_ORIGINS=http://localhost:8100,https://sub.mydomain.com