feature: add postgraphile-tag-json-tools for json schema generation#206
Open
phryneas wants to merge 1 commit intographile:mainfrom
Open
feature: add postgraphile-tag-json-tools for json schema generation#206phryneas wants to merge 1 commit intographile:mainfrom
phryneas wants to merge 1 commit intographile:mainfrom
Conversation
for json schema generation
benjie
requested changes
Oct 9, 2020
Member
benjie
left a comment
There was a problem hiding this comment.
This is really cool! It could do with a smidge of docs; could you put some in the @app/server/README.md file referencing the two newly created file names and a link to postgraphile-tag-json-tools please?
Comment on lines
+189
to
+194
| ...(!isDev | ||
| ? [] | ||
| : [ | ||
| // updates the `pg-database-smart-tags.schema.json` file based on the database | ||
| CreateJsonSchemaPlugin, | ||
| ]), |
Member
There was a problem hiding this comment.
Avoiding the negative makes this easier to read IMO.
Suggested change
| ...(!isDev | |
| ? [] | |
| : [ | |
| // updates the `pg-database-smart-tags.schema.json` file based on the database | |
| CreateJsonSchemaPlugin, | |
| ]), | |
| ...(isDev | |
| ? [ | |
| // updates the `pg-database-smart-tags.schema.json` file based on the database | |
| CreateJsonSchemaPlugin, | |
| ] | |
| : []), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like requested in #205
Description
This PR only uses the
createJsonSchemapart ofpostgraphile-tag-json-tools, asextractSmartTagsandloadSmartTagsfunctionalities do not seem necessary here.Changes in the database will update
@app/server/pg-database-smart-tags.schema.json, but edits in@app/server/pg-smart-tags.schema.jsonwill persist, so additional tags can be added without fear of something being overridden. (I added simpleCollections and resultFieldName, as I didn't have those in my initial schema - if you can think of any more tags, please mention them & I will add them.)I've marked the place to add new tags with
"$comment": "------ Add extra tags here, inproperties. ------",.Performance impact
None in production use, probably neglectable in dev mode.
Security impact
None in production use, nothing I could think of in dev use.
Checklist
yarn lint:fixpasses.yarn testpasses.RELEASE_NOTES.mdfile (if one exists).