feat: add --skip-merkle flag to correct-last-epoch command#271
Open
pcarranzav wants to merge 1 commit intomainfrom
Open
feat: add --skip-merkle flag to correct-last-epoch command#271pcarranzav wants to merge 1 commit intomainfrom
pcarranzav wants to merge 1 commit intomainfrom
Conversation
Adds a new --skip-merkle flag that skips merkle root computation and uses a zero merkle root (32 bytes of zeros) instead. This is useful when multiple networks need correction, as it avoids potential failures when fetching non-existent blocks from other chains. The implementation: - Skips RPC client initialization for non-target chains when flag is set - Still initializes target chain RPC if block number needs auto-detection - Uses 0x0000...0000 (32 bytes) as the merkle root - Maintains all other validation and output formatting 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--skip-merkleflag to thecorrect-last-epochcommand that skips merkle root computationMotivation
This feature is useful when multiple networks need correction. Previously, if we tried to fetch the last reported block for a network and it was a non-existent block, the script would fail. With
--skip-merkle, we can bypass fetching blocks from other chains entirely, avoiding these failures.Changes
--skip-merkleCLI flag toCorrectLastEpochcommand--skip-merkleis set and block number is provided: skip all RPC initialization--skip-merkleis set but block number needs auto-detection: only initialize target chain RPC--skip-merkleis not set: initialize all RPCs (existing behavior)Test plan
--skip-merkleflag--skip-merkleand explicit block number--skip-merkleand auto-detected block number🤖 Generated with Claude Code