Add description to schema parser and printer#284
Open
benjaminjkraft wants to merge 4 commits intographql-python:masterfrom
Open
Add description to schema parser and printer#284benjaminjkraft wants to merge 4 commits intographql-python:masterfrom
benjaminjkraft wants to merge 4 commits intographql-python:masterfrom
Conversation
The indent function wasn't actually indenting. Add the indent to the function and fix up the one call site.
Descriptions are now part of the [graphql spec](https://facebook.github.io/graphql/June2018/#sec-Descriptions). This commit brings graphql-core inline with the spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated version of #222 by @phil303 -- I just resolved the merge conflict and fixed a small bug. If maintainers are interested, I'm happy to do the work to try to get this merged; if not it's here in case it's useful to anyone else.