-
Notifications
You must be signed in to change notification settings - Fork 2k
Implement MFA service's ReplicateValidatedMFAChallenge RPC. #63465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+413
−85
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5c42524
Implement MFA service's ReplicateValidatedMFAChallenge RPC.
cthach 573983d
Restrict authz to just remote proxy.
cthach 9001e60
Fix spelling and be consistent.
cthach 54125a9
Rename to isRemoteProxy.
cthach 8cb2d05
Use ErrorIs.
cthach 4538c84
Merge branch 'master' into cthach/impl-replicate-mfa-rpc
cthach 43746a1
Merge branch 'master' into cthach/impl-replicate-mfa-rpc
cthach 970e442
Merge branch 'master' into cthach/impl-replicate-mfa-rpc
cthach d2e6c8e
Use constant types.V1.
cthach 3c5f3db
Merge branch 'master' into cthach/impl-replicate-mfa-rpc
cthach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace with constant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know we had a constant for that. Thank you!
Replaced in d2e6c8e