feat(design, storefront)!: move DaffQuantityFieldComponent into the storefront package#4121
Open
feat(design, storefront)!: move DaffQuantityFieldComponent into the storefront package#4121
DaffQuantityFieldComponent into the storefront package#4121Conversation
xelaint
added
package: design
xelaint
changed the title
xelaint
changed the title
DaffFormFieldControl in DaffQuantityFieldComponent
xelaint
added
the
🚨 breaking changes
xelaint
force-pushed
the
quantity-field-update
branch
2 times, most recently
from
eca7788 to
32dfffa
Compare
xelaint
force-pushed
the
quantity-field-update
branch
from
17c3efe to
43b2266
Compare
xelaint
force-pushed
the
quantity-field-update
branch
from
43b2266 to
96e82e5
Compare
Member
Author
|
@damienwebdev moved quantity field to |
xelaint
changed the title
DaffFormFieldControl in DaffQuantityFieldComponentDaffQuantityFieldComponent into the storefront package
xelaint
added
status: pending review
damienwebdev
requested changes
Dec 4, 2025
| padding: 1rem 0; | ||
| } | ||
|
|
||
| &.is-quantity-select, |
Member
There was a problem hiding this comment.
This dependency is wrong. Design shouldn't know about storefront.
| } | ||
|
|
||
| /** @docs-private */ | ||
| get isQuantitySelect() { |
Member
There was a problem hiding this comment.
This function shouldn't exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Replace inputs with signals in order to handle focus changes.
Currently, focus does not transition when select changes to an input.
Fixes: #3888
Part of: #416, #3799
New behavior
Breaking change?
BREAKING CHANGE: The quantity field component has been moved from
@daffodil/designto@daffodil/storefront.Additional context