feat(product): transfer state when hydrating backend from server to client#4148
Open
damienwebdev wants to merge 2 commits intodevelopfrom
Open
feat(product): transfer state when hydrating backend from server to client#4148damienwebdev wants to merge 2 commits intodevelopfrom
damienwebdev wants to merge 2 commits intodevelopfrom
Conversation
griest024
requested changes
Oct 27, 2025
Comment on lines
+45
to
+49
| transferState = inject(TransferState); | ||
|
|
||
| platform = inject(PLATFORM_ID); | ||
|
|
||
| productFactory = inject(DaffProductExtensionFactory); |
Member
There was a problem hiding this comment.
It doesn't seem like these need to be fields of this class, just inject in constructor and use locally.
| ).data, | ||
| ); | ||
| } else { | ||
| this.transferState.set(TRANSFER_STATE_KEY, { data: JSON.stringify(this._products) }); |
Member
There was a problem hiding this comment.
Where are the products actually being created?
| this._products = JSON.parse( | ||
| this.transferState.get( | ||
| TRANSFER_STATE_KEY, | ||
| { data: JSON.stringify(this.productFactory.createMany(35)) }, |
Member
There was a problem hiding this comment.
Do we need to do serialization ourselves? TransferState should handle that:
The values in the store are serialized/deserialized using JSON.stringify/JSON.parse. So only boolean, number, string, null and non-class objects will be serialized and deserialized in a non-lossy manner.
griest024
added
the
status: needs response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Part of: #4143
New behavior
Product backend data is transferred when hydrating backend from server to client.
Breaking change?
Additional context
Depends on #4147