refactor(demo): Convert checkout to standalone#4307
Open
joannalauu wants to merge 2 commits intodevelopfrom
Open
refactor(demo): Convert checkout to standalone#4307joannalauu wants to merge 2 commits intodevelopfrom
joannalauu wants to merge 2 commits intodevelopfrom
Conversation
210594a to
0e7358a
Compare
xelaint
requested changes
Jan 28, 2026
| { | ||
| path: 'checkout', | ||
| loadChildren: () => import('./checkout/checkout.module').then(m => m.CheckoutModule), | ||
| loadChildren: () => import('./checkout/checkout.routes').then(m => m.demoCheckoutRoutes), |
Member
There was a problem hiding this comment.
Suggested change
| loadChildren: () => import('./checkout/checkout.routes').then(m => m.demoCheckoutRoutes), | |
| loadChildren: () => import('./checkout/checkout.routes').then(r => r.demoCheckoutRoutes), |
8599518 to
d4599ae
Compare
d4599ae to
1d3bac5
Compare
xelaint
requested changes
Feb 2, 2026
| DemoCheckoutAddressFormComponent, | ||
| ReactiveFormsModule, | ||
| DaffButtonComponent, | ||
| DAFF_BUTTON_COMPONENTS, |
Member
There was a problem hiding this comment.
Suggested change
| DAFF_BUTTON_COMPONENTS, | |
| DAFF_BASIC_BUTTON_COMPONENTS, |
| DemoCheckoutShippingOptionsComponent, | ||
| ReactiveFormsModule, | ||
| DaffButtonComponent, | ||
| DAFF_BUTTON_COMPONENTS, |
Member
There was a problem hiding this comment.
Suggested change
| DAFF_BUTTON_COMPONENTS, | |
| DAFF_BASIC_BUTTON_COMPONENTS, |
1d3bac5 to
40aa065
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Fixes: #
Part of: #3664
New behavior
Checkout in demo app is now standalone. Modules have been removed.
Breaking change?
Additional context