Skip to content

refactor(demo): Convert checkout to standalone#4307

Open
joannalauu wants to merge 2 commits intodevelopfrom
refactor/demo/checkout
Open

refactor(demo): Convert checkout to standalone#4307
joannalauu wants to merge 2 commits intodevelopfrom
refactor/demo/checkout

Conversation

@joannalauu
Copy link
Contributor

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

Current behavior

Fixes: #
Part of: #3664

New behavior

Checkout in demo app is now standalone. Modules have been removed.

Breaking change?

  • Yes
  • No

Additional context

@joannalauu joannalauu requested review from a team as code owners January 27, 2026 23:27
@joannalauu joannalauu force-pushed the refactor/demo/checkout branch 2 times, most recently from 210594a to 0e7358a Compare January 28, 2026 20:40
{
path: 'checkout',
loadChildren: () => import('./checkout/checkout.module').then(m => m.CheckoutModule),
loadChildren: () => import('./checkout/checkout.routes').then(m => m.demoCheckoutRoutes),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
loadChildren: () => import('./checkout/checkout.routes').then(m => m.demoCheckoutRoutes),
loadChildren: () => import('./checkout/checkout.routes').then(r => r.demoCheckoutRoutes),

@joannalauu joannalauu force-pushed the refactor/demo/checkout branch from 8599518 to d4599ae Compare January 28, 2026 21:55
@joannalauu joannalauu requested a review from xelaint January 28, 2026 22:00
@joannalauu joannalauu force-pushed the refactor/demo/checkout branch from d4599ae to 1d3bac5 Compare February 1, 2026 02:20
DemoCheckoutAddressFormComponent,
ReactiveFormsModule,
DaffButtonComponent,
DAFF_BUTTON_COMPONENTS,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DAFF_BUTTON_COMPONENTS,
DAFF_BASIC_BUTTON_COMPONENTS,

DemoCheckoutShippingOptionsComponent,
ReactiveFormsModule,
DaffButtonComponent,
DAFF_BUTTON_COMPONENTS,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DAFF_BUTTON_COMPONENTS,
DAFF_BASIC_BUTTON_COMPONENTS,

@xelaint xelaint requested a review from damienwebdev February 3, 2026 16:58
@joannalauu joannalauu force-pushed the refactor/demo/checkout branch from 1d3bac5 to 40aa065 Compare February 3, 2026 18:22
@joannalauu joannalauu requested a review from xelaint February 3, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants