feat(design): add aria-controls support to DaffMenuComponent#4315
Open
fiona-cai wants to merge 3 commits intograycoreio:developfrom
Open
feat(design): add aria-controls support to DaffMenuComponent#4315fiona-cai wants to merge 3 commits intograycoreio:developfrom
aria-controls support to DaffMenuComponent#4315fiona-cai wants to merge 3 commits intograycoreio:developfrom
Conversation
xelaint
added
package: design
xelaint
changed the title
aria-controls support to DaffMenuComponent
Assistive technologies need a stable association between the menu activator and the menu panel. Previously the menu had no id and the activator had no aria-controls. - Add unique id on DaffMenuComponent (generated + optional @input override) - Set aria-controls on daffMenuActivator linked to menu id via DAFF_MENU_ID token - Update DaffMenuService to pass menuId when opening and inject into portal - Add unit tests and documentation for id and aria-controls behavior Closes graycoreio#4159
fiona-cai
force-pushed
the
feat/aria-controls
branch
from
5b0b85b to
6da7606
Compare
… in spec The test must use toHaveBeenCalledWith to satisfy lint but cannot reference the directive's private viewContainerRef. Assert the first argument with jasmine.anything() and the remaining args as before.
xelaint
requested changes
Feb 2, 2026
Member
xelaint
left a comment
xelaint
left a comment
There was a problem hiding this comment.
fix(design): resolve spec failures in textarea, tree, and progress-bar should be moved to a separate PR
Contributor
Author
is there a current issue open for it? |
Member
I created the issue since the updates are valid, but these tests don't actually fail on my end since the tests itself don't rely on the missing imports. Are they actually causing a fail on your end? |
Contributor
Author
|
yeah, they do |
…ssertion Assert only the third argument (menu id); second arg can be TemplateRef before component.daffMenuActivator is set in test context.
fiona-cai
force-pushed
the
feat/aria-controls
branch
from
1acbea7 to
6542048
Compare
Member
okay that's interesting since the CI pipeline passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Fixes: #4159
New behavior
Breaking change?
Additional context