feat(design): DaffModalService.open returns reference instead of modal instance#4321
Open
joannalauu wants to merge 1 commit intodevelopfrom
Open
feat(design): DaffModalService.open returns reference instead of modal instance#4321joannalauu wants to merge 1 commit intodevelopfrom
DaffModalService.open returns reference instead of modal instance#4321joannalauu wants to merge 1 commit intodevelopfrom
Conversation
xelaint
added
package: design
damienwebdev
requested changes
Feb 6, 2026
Member
damienwebdev
left a comment
damienwebdev
left a comment
There was a problem hiding this comment.
I think this is a good starting point.
|
|
||
| import { DaffModalComponent } from '../modal.component'; | ||
|
|
||
| export interface DaffModal { |
Member
There was a problem hiding this comment.
split this into two files I think to avoid accidental public_api exposure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Fixes: #4270
Part of: #
New behavior
DaffModalService.openreturns reference instead of modal instance. The reference provides access toclose()and theafterClosedobservable.Breaking change?
Additional context