Open
Conversation
Collaborator
|
That's a good opinion. |
Collaborator
|
I will consider whether it is possible to change it in the current structure (TableHeadCell - TableHeadCellNoDnD) |
Author
|
Thanks for the review. This PR was a quickfix and indeed not very "DRY". HOC is indeed a good idea and I will try to get back to you in the next few days with a proposal. However, the cleanest way in my opinion would be to put back the conditional calls on the hooks following the value of isDraggingEnabled.I don't think there are cases where a backend is provided or not dynamically, so a conditional call on hooks should not be a problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows #1536 which allows to manage cases where no DND backend is provided.
The original PR conditionally called the hooks "useDrag" and "useColumnDrop" in the TableHeadCell component, but it seems that these changes have been overwritten in commit e75d2fe. Therefore, a bug appears in the TableHeadCell component if no DnDbackend is provided (which is quite a neat feature).
So I propose a quickfix in which I created a new component named TableHeadCellNoDnd which is called if dragNDrop is not explicitly enabled.
I added a working example of a table to which is passed "components={{DragDropBackend: null}}".