Skip to content

Canvas build CI failure#518

Closed
softmarshmallow wants to merge 9 commits intomainfrom
chore/canvas-build-ci-failure-731b
Closed

Canvas build CI failure#518
softmarshmallow wants to merge 9 commits intomainfrom
chore/canvas-build-ci-failure-731b

Conversation

@softmarshmallow
Copy link
Member

@softmarshmallow softmarshmallow commented Feb 1, 2026

This pull request contains changes generated by a Cursor Cloud Agent

Open in Cursor Open in Web

Summary by CodeRabbit

  • Chores
    • Enhanced WebAssembly build configuration for improved exception handling and error recovery support in the canvas rendering system.

✏️ Tip: You can customize this high-level summary in your review settings.

cursoragent and others added 5 commits February 1, 2026 16:48
Co-authored-by: universe <universe@grida.co>
Co-authored-by: universe <universe@grida.co>
Co-authored-by: universe <universe@grida.co>
Co-authored-by: universe <universe@grida.co>
Co-authored-by: universe <universe@grida.co>
@cursor
Copy link

cursor bot commented Feb 1, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@vercel
Copy link

vercel bot commented Feb 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Feb 4, 2026 6:04pm
grida Ready Ready Preview, Comment Feb 4, 2026 6:04pm
5 Skipped Deployments
Project Deployment Actions Updated (UTC)
code Ignored Ignored Feb 4, 2026 6:04pm
legacy Ignored Ignored Feb 4, 2026 6:04pm
backgrounds Skipped Skipped Feb 4, 2026 6:04pm
blog Skipped Skipped Feb 4, 2026 6:04pm
viewer Skipped Skipped Feb 4, 2026 6:04pm

Request Review

@coderabbitai
Copy link

coderabbitai bot commented Feb 1, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Walkthrough

Configuration changes to the Emscripten WebAssembly build target, adding linker flags and environment variables to enable setjmp/longjmp support and legacy WebAssembly exception handling during compilation and linking of the canvas-wasm crate.

Changes

Cohort / File(s) Summary
WebAssembly Exception Handling Configuration
crates/grida-canvas-wasm/.cargo/config.toml, crates/grida-canvas-wasm/justfile
Added linker flags (-sSUPPORT_LONGJMP=wasm, -sWASM_LEGACY_EXCEPTIONS=1) and SKIA build arguments to enable setjmp/longjmp and legacy exception handling support for the wasm32-unknown-emscripten target.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • emsdk 5.0.0 #506: Directly modifies the same crates/grida-canvas-wasm/.cargo/config.toml file to adjust wasm exception and Emscripten linker configuration flags.

Poem

🐰 With flags and args, we hop and leap,
To catch exceptions, stored so deep,
Longjmp and wasm, hand in hand,
Our canvas now across the land! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Canvas build CI failure' is vague and does not clearly describe the specific changes made. It mentions a problem but doesn't convey what was actually fixed or changed in the codebase. Consider a more descriptive title such as 'Configure wasm linker flags for exception handling support' or 'Fix canvas wasm build with setjmp/longjmp support' to better reflect the actual code changes made.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/canvas-build-ci-failure-731b

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: universe <universe@grida.co>
Co-authored-by: universe <universe@grida.co>
Co-authored-by: Universe <universe@grida.co>
Co-authored-by: Universe <universe@grida.co>
@vercel vercel bot temporarily deployed to Preview – blog February 4, 2026 18:02 Inactive
@vercel vercel bot temporarily deployed to Preview – backgrounds February 4, 2026 18:02 Inactive
@softmarshmallow
Copy link
Member Author

duplicate #524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants