Open
Conversation
The committers listed above are authorized under a signed CLA. |
Member
|
@arjan-bal, can you review since this is for Go? |
arjan-bal
reviewed
Sep 10, 2024
Contributor
arjan-bal
left a comment
arjan-bal
left a comment
There was a problem hiding this comment.
There are separate tables for OAuth and TLS examples, and links for Go seem to be correct in both. I don't think any changes are required here.
| [Go Example]: https://github.com/grpc/grpc-go/tree/master/examples/features/encryption | ||
| [Go Documentation]: https://github.com/grpc/grpc-go/tree/master/examples/features/encryption#encryption | ||
| [Go Example]: https://github.com/grpc/grpc-go/tree/master/examples/features/authentication | ||
| [Go Documentation]: https://github.com/grpc/grpc-go/tree/master/examples/features/authentication#encryption |
Contributor
There was a problem hiding this comment.
Since there is no #encryption section on the page, this link seems broken.
Comment on lines
+216
to
+217
| [Go Example]: https://github.com/grpc/grpc-go/tree/master/examples/features/authentication | ||
| [Go Documentation]: https://github.com/grpc/grpc-go/tree/master/examples/features/authentication#encryption |
Contributor
There was a problem hiding this comment.
This table is for language specific TLS examples. So the Go links seems to correctly point to the encryption directory. The table just below this is for OAuth examples, in which the Go row points to the links you've added in this PR.
grpc.io/content/en/docs/guides/auth.md
Lines 224 to 238 in f4a96fb
Reallyfe
approved these changes
Dec 5, 2024
Reallyfe
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.