fix(lifecycle): extract one-liner from summary body when not in frontmatter#921
Open
j2h4u wants to merge 1 commit intogsd-build:mainfrom
Open
fix(lifecycle): extract one-liner from summary body when not in frontmatter#921j2h4u wants to merge 1 commit intogsd-build:mainfrom
j2h4u wants to merge 1 commit intogsd-build:mainfrom
Conversation
…matter The summary template puts the one-liner as a `**bold**` line after the `# Phase N` heading, but `cmdSummaryExtract` and `cmdMilestoneComplete` only checked frontmatter `one-liner` field — which is often empty. Adds `extractOneLinerFromBody()` to core.cjs as a fallback that parses the first `**...**` line after the heading. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
extractOneLinerFromBody()helper to core.cjs, used as fallback incmdSummaryExtractandcmdMilestoneCompletewhen the frontmatterone-linerfield is empty.Why
The summary template writes the one-liner as a
**bold**markdown line after the# Phase Nheading, but the code only checked frontmatter'sone-linerfield — which is often empty. This causedsummary-extractto returnnullandmilestone completeto miss accomplishments.Testing
Checklist
Breaking Changes
None