fix(update): make /gsd:update runtime-aware and target correct runtime#931
Open
obouafif wants to merge 1 commit intogsd-build:mainfrom
Open
fix(update): make /gsd:update runtime-aware and target correct runtime#931obouafif wants to merge 1 commit intogsd-build:mainfrom
obouafif wants to merge 1 commit intogsd-build:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When multiple runtimes are installed (for example Claude + Codex),
/gsd:updatecould target the wrong runtime because the update workflow did not explicitly carry runtime selection through to install execution.In practice, Codex users could end up with Claude-targeted update behavior instead of a Codex-targeted update path.
What this changes
claude,opencode,gemini,codex).PREFERRED_RUNTIME(derived from execution context, with env-var fallback).LOCAL/GLOBAL/UNKNOWN)npx -y get-shit-done-cc@latest "--$TARGET_RUNTIME" --local|--global--claude --globalWhy this is correct
The installer already supports explicit runtime flags (
--claude,--opencode,--gemini,--codex). This change ensures/gsd:updatepasses the right runtime explicitly instead of relying on default behavior.Validation
npm test