Add Progressive Tab Scrolling Representation#17
Open
kareem-hewady wants to merge 1 commit intoguilhermearaujo:masterfrom
kareem-hewady:master
Open
Add Progressive Tab Scrolling Representation#17kareem-hewady wants to merge 1 commit intoguilhermearaujo:masterfrom kareem-hewady:master
kareem-hewady wants to merge 1 commit intoguilhermearaujo:masterfrom
kareem-hewady:master
Conversation
Progressive Scrolling is that the line below the tab titles to represent touch movements accurately and continuously. So it doesn’t jump suddenly as previously. I added a new public property to enable or disable the functionality (enabled by default). It was done by conforming to the UIScrollViewDelegate to get the ContentOffset and then use it to move the line. The width also changes dynamically to accommodate the next titles. Also a minor bug was fixed that caused the line to be stuck in its former position when changing orientation.
Owner
|
What exactly do you mean by "counter intuitive way"? |
Author
|
Going left or right half the way and the cancelling the touch. The bar
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some feedback from a user that the line below the tab was moving in a counter intuitive way. So I modified the behavior a bit and it suits my app better this way. I thought I'd share the change in case you like it.