rework modtowerhelper.finalizehero skins, add gamemodel.getherowithnameandlevel patch#310
Open
Onixiya wants to merge 1 commit intogurrenm3:masterfrom
Open
rework modtowerhelper.finalizehero skins, add gamemodel.getherowithnameandlevel patch#310Onixiya wants to merge 1 commit intogurrenm3:masterfrom
Onixiya wants to merge 1 commit intogurrenm3:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr is made with a incompatibility with my stuff and mod helper a user has noticed.
rework modtowerhelper.finalizehero skins to not use a dictionary and directly read from the skinlist.items array for skin related data. add gamemodel.getherowithnameandlevel patch which appears to be the method responsible for breaking heroupgradedetails.binddetails this time.
also a change to vanillaspritegenerator so the damn thing would compile. I have 0 idea if it works but it compiles so idgaf.
i've left the getfontmaterial, getbackgroundbanner and getbackgroundcolour methods there as while they don't appear to be used in other places in mod helper, they might be used in other mods as they are public so idfk if you want to deprecate those.
https://discord.com/channels/504782676331331584/872504918831939625/1396121155982721135