Add template support for promise interface#177
Open
drealecs wants to merge 2 commits intoguzzle:2.0from
Open
Conversation
|
Same here.. Surprised that it's not there already.. |
|
This would be a welcome addition @GrahamCampbell 🙇 |
|
I would welcome this change very much, but it seems to be stalled. Is there a reason for this? Is there any way to help moving this forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will try again to add template support for promises, hopefully in a simpler way that would work both with phpstan and psalm.
For #163.