Skip to content

fix: only use --wait if explicitly set to true #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
genisd merged 1 commit into from
Nov 6, 2025
Merged

fix: only use --wait if explicitly set to true #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ async function run() {
if (version) args.push(`--set=app.version=${version}`);
if (chartVersion) args.push(`--version=${chartVersion}`);
if (timeout) args.push(`--timeout=${timeout}`);
if (wait) args.push(`--wait`);
if (wait === "true") args.push(`--wait`);
if (repository) args.push(`--repo=${repository}`);
valueFiles.forEach((f) => args.push(`--values=${f}`));
args.push("--values=./values.yml");
Expand Down
4 changes: 2 additions & 2 deletions tests/scenarios/helm.sh.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@ gcloud auth activate-service-account --key-file=sa.json
gcloud container clusters get-credentials clusterName --zone GKElocation --project GKEproject --account example@example.com
::debug::env: KUBECONFIG="undefined"
::debug::rendering value files [./values.yml] with: {"secrets":{"secret":"val"}}
[command]/tmp/bin/helm upgrade app /usr/src/charts/app --install --namespace=default --set=app.name=app --set=app.version=1234 --wait --values=./values.yml --atomic
helm upgrade app /usr/src/charts/app --install --namespace=default --set=app.name=app --set=app.version=1234 --wait --values=./values.yml --atomic
[command]/tmp/bin/helm upgrade app /usr/src/charts/app --install --namespace=default --set=app.name=app --set=app.version=1234 --values=./values.yml --atomic
helm upgrade app /usr/src/charts/app --install --namespace=default --set=app.name=app --set=app.version=1234 --values=./values.yml --atomic
::debug::not setting deployment status
2 changes: 1 addition & 1 deletion tests/scenarios/production.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ INPUT_NAMESPACE=default \
INPUT_RELEASE=app \
INPUT_VERSION=1234 \
INPUT_TRACK=stable \
INPUT_TIMEOUT=30 \
INPUT_TIMEOUT='5m' \
INPUT_VALUES='{"replicaCount": 1, "image": {"repository": "nginx", "tag": "latest"}}' \
node ../index.js
6 changes: 3 additions & 3 deletions tests/scenarios/production.sh.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
::debug::param: version = "1234"
::debug::param: secrets = "{"secret":"val"}"
::debug::param: valueFiles = "[]"
::debug::param: timeout = "30"
::debug::param: timeout = "5m"
::debug::param: wait = "false"
::debug::param: repository = ""
::debug::param: atomic = "true"
Expand All @@ -29,6 +29,6 @@ gcloud auth activate-service-account --key-file=sa.json
gcloud container clusters get-credentials clusterName --zone GKElocation --project GKEproject --account example@example.com
::debug::env: KUBECONFIG="undefined"
::debug::rendering value files [./values.yml] with: {"secrets":{"secret":"val"}}
[command]/tmp/bin/helm upgrade app /usr/src/charts/app --install --namespace=default --set=app.name=app --set=app.version=1234 --timeout=30 --wait --values=./values.yml --atomic
helm upgrade app /usr/src/charts/app --install --namespace=default --set=app.name=app --set=app.version=1234 --timeout=30 --wait --values=./values.yml --atomic
[command]/tmp/bin/helm upgrade app /usr/src/charts/app --install --namespace=default --set=app.name=app --set=app.version=1234 --timeout=5m --values=./values.yml --atomic
helm upgrade app /usr/src/charts/app --install --namespace=default --set=app.name=app --set=app.version=1234 --timeout=5m --values=./values.yml --atomic
::debug::not setting deployment status
4 changes: 2 additions & 2 deletions tests/scenarios/timeout.sh.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@ gcloud auth activate-service-account --key-file=sa.json
gcloud container clusters get-credentials clusterName --zone GKElocation --project GKEproject --account example@example.com
::debug::env: KUBECONFIG="undefined"
::debug::rendering value files [./values.yml] with: {"secrets":{"secret":"val"}}
[command]/tmp/bin/helm upgrade app /usr/src/charts/app --install --namespace=default --set=app.name=app --set=app.version=1234 --timeout=5m --wait --values=./values.yml --atomic
helm upgrade app /usr/src/charts/app --install --namespace=default --set=app.name=app --set=app.version=1234 --timeout=5m --wait --values=./values.yml --atomic
[command]/tmp/bin/helm upgrade app /usr/src/charts/app --install --namespace=default --set=app.name=app --set=app.version=1234 --timeout=5m --values=./values.yml --atomic
helm upgrade app /usr/src/charts/app --install --namespace=default --set=app.name=app --set=app.version=1234 --timeout=5m --values=./values.yml --atomic
::debug::not setting deployment status
4 changes: 2 additions & 2 deletions tests/scenarios/ttl.sh.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ gcloud auth activate-service-account --key-file=sa.json
gcloud container clusters get-credentials clusterName --zone GKElocation --project GKEproject --account example@example.com
::debug::env: KUBECONFIG="undefined"
::debug::rendering value files [./values.yml] with: {"secrets":{"secret":"val"}}
[command]/tmp/bin/helm upgrade app-pr-123 /usr/src/charts/app --install --namespace=default --set=app.name=app-pr-123 --set=app.version=1234 --wait --values=./values.yml --atomic
helm upgrade app-pr-123 /usr/src/charts/app --install --namespace=default --set=app.name=app-pr-123 --set=app.version=1234 --wait --values=./values.yml --atomic
[command]/tmp/bin/helm upgrade app-pr-123 /usr/src/charts/app --install --namespace=default --set=app.name=app-pr-123 --set=app.version=1234 --values=./values.yml --atomic
helm upgrade app-pr-123 /usr/src/charts/app --install --namespace=default --set=app.name=app-pr-123 --set=app.version=1234 --values=./values.yml --atomic
Setting ttl: 7 days
[command]/tmp/bin/helm --namespace=default release ttl app-pr-123 --service-account=helm-ttl-plugin --set=7 days
helm --namespace=default release ttl app-pr-123 --service-account=helm-ttl-plugin --set=7 days
Expand Down