Fix predicated load/store of one-lane vectors#8924
Open
alexreinking wants to merge 2 commits intomainfrom
Open
Fix predicated load/store of one-lane vectors#8924alexreinking wants to merge 2 commits intomainfrom
alexreinking wants to merge 2 commits intomainfrom
Conversation
abadams
approved these changes
Jan 27, 2026
mcourteaux
reviewed
Jan 30, 2026
| // This schedule creates a situation where f1 is computed with a | ||
| // vectorized loop that requires predicated loads/stores for the | ||
| // final single element. | ||
| f2.split(x, xo, xi, w); |
Contributor
There was a problem hiding this comment.
Shouldn't you explicitly select a Predicated tail strategy? Auto might select guard with if?
Member
There was a problem hiding this comment.
GuardWithIf currently generates a predicate, but yes it might be more future proof to use TailStrategy::Predicate here
| // vectorized loop that requires predicated loads/stores for the | ||
| // final single element. | ||
| f2.split(x, xo, xi, w); | ||
| f1.compute_at(f2, xo).vectorize(x); // effective vector width = w + 1 |
Contributor
There was a problem hiding this comment.
Or in vectorize set the tail strategy?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8922