Add rfactor patterns for index-first argmax/argmin#8932
Open
alexreinking wants to merge 11 commits intomainfrom
Open
Add rfactor patterns for index-first argmax/argmin#8932alexreinking wants to merge 11 commits intomainfrom
alexreinking wants to merge 11 commits intomainfrom
Conversation
alexreinking
commented
Feb 4, 2026
Comment on lines
+106
to
+113
| debug(5) << "Found associative ops for " << e << " -> " << op << ":\n" | ||
| << [&] { | ||
| std::stringstream ss; | ||
| for (const auto &[var, val] : result) { | ||
| ss << " " << var << " -> " << val << "\n"; | ||
| } | ||
| return ss.str(); | ||
| }(); |
Member
Author
There was a problem hiding this comment.
"Fun" fact: without this patch, we get a segfault when HL_DEBUG_CODEGEN is set to print this message. When the associative op is in the second tuple component, only y1 is in the result, yet the lookup itself will add an entry to for y0, with an undefined Expr for the value. Later, the expr_uses_vars check will try to visit the undefined Expr and a null pointer gets dereferenced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add patterns to the associative ops table to allow writing argmin/argmax as (index, value) pairs. Previously, rfactor supported only (value, index) because it would fail to prove associativity.
Doing this required reworking the code that converted a matched expression back into a pattern over the new variable names. It did this completely backwards for some reason: trying to match large fragments of IR and replacing them with the placeholder names. But we just matched the pattern in the table! So I'm proceeding by renaming the table patterns directly. I don't see why this shouldn't work, but I've only run
correctness_rfactorand_test_internallocally, so we'll see what the bots say.Added tests for the inline reduction helpers, too.
ATTN @stevenraphael