Open
Conversation
jubinchheda
commented
May 28, 2024
jubinchheda
commented
- Use a set for split_indices and predictions to speed up lookup times.
- Read files in a more efficient manner using with statements to ensure proper file handling.
- Simplify the loop by combining conditions and removing redundant checks.
- Use list comprehensions for filtering and counting.
* Use a set for split_indices and predictions to speed up lookup times. * Read files in a more efficient manner using with statements to ensure proper file handling. * Simplify the loop by combining conditions and removing redundant checks. * Use list comprehensions for filtering and counting.
xufengduan
approved these changes
May 29, 2024
Author
|
Can we merge this pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.