Respond with error for unhandled content encodings#103
Open
kanongil wants to merge 2 commits intohapijs:nextfrom
Open
Respond with error for unhandled content encodings#103kanongil wants to merge 2 commits intohapijs:nextfrom
kanongil wants to merge 2 commits intohapijs:nextfrom
Conversation
kanongil
added
bug
Marsup
approved these changes
Aug 4, 2025
Contributor
Marsup
left a comment
Marsup
left a comment
There was a problem hiding this comment.
Looks legit, did it cause you real world problem? I'm wondering whether it should be breaking change or not.
Contributor
Author
|
No real world issue here, just stumbled upon the inconsistency. Feel free to merge as a non-breaking bug fix, if you prefer. I doubt there is anyone that relies on the current behaviour. |
This allows clients to determine a valid encoding See https://datatracker.ietf.org/doc/html/rfc9110#name-accept-encoding
It's a real world problem when it comes to disabling decompression 🗜 -> hapijs/hapi#4549 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be a more appropriate response.
Link: https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Status/415