Fix/Add CHECK_FOR_INTERRUPTS to health check worker to prevent DROP …#1108
Open
akankshahu wants to merge 1 commit intohapostgres:mainfrom
Open
Fix/Add CHECK_FOR_INTERRUPTS to health check worker to prevent DROP …#1108akankshahu wants to merge 1 commit intohapostgres:mainfrom
akankshahu wants to merge 1 commit intohapostgres:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes issue #1063 where DROP DATABASE operations would hang when health check workers were running. The fix adds proper interrupt handling to allow health check workers to respond promptly to termination signals.
Changes:
- Added CHECK_FOR_INTERRUPTS() calls in health check worker loops to enable proper signal handling
- Added explicit got_sigterm checks after connection establishment and latch wakeup for faster shutdown
- Added comprehensive test suite to verify DROP DATABASE operations complete without hanging
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/monitor/health_check_worker.c | Added interrupt checking in HealthCheckWorkerMain and DoHealthChecks loops, plus explicit SIGTERM checks after connection and latch wait for fast exit |
| tests/test_drop_database.py | New comprehensive test suite covering basic DROP, DROP WITH FORCE, multiple sequential drops, and worker cleanup verification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…DATABASE hangs (#1063)