Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the PuppeteerSharp project from .NET 8 to .NET 10, updating target frameworks, SDK versions, and modernizing the test server implementation.
Changes:
- Updated all project target frameworks from net8.0 to net10.0
- Migrated SimpleServer from IWebHost/WebHostBuilder to WebApplication minimal hosting model
- Updated GitHub Actions workflows to use .NET 10.0.x SDK
- Removed obsolete package references for .NET 10 compatibility
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/PuppeteerSharp/PuppeteerSharp.csproj | Updated target framework to net10.0 and analysis level to 10.0-Recommended |
| lib/PuppeteerSharp.Tooling/PuppeteerSharp.Tooling.csproj | Updated target framework to net10.0 |
| lib/PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj | Updated target framework to net10.0 and removed obsolete package references |
| lib/PuppeteerSharp.Tests.SingleFileDeployment/PuppeteerSharp.Tests.SingleFileDeployment.csproj | Updated target framework to net10.0 |
| lib/PuppeteerSharp.Tests.DumpIO/PuppeteerSharp.Tests.DumpIO.csproj | Updated target framework to net10.0 |
| lib/PuppeteerSharp.TestServer/SimpleServer.cs | Migrated from IWebHost to WebApplication minimal hosting model, updated namespace imports |
| lib/PuppeteerSharp.TestServer/PuppeteerSharp.TestServer.csproj | Updated target framework to net10.0 |
| lib/PuppeteerSharp.Nunit/PuppeteerSharp.Nunit.csproj | Updated target framework to net10.0 |
| lib/PuppeteerSharp.DevicesFetcher/PuppeteerSharp.DevicesFetcher.csproj | Updated target framework to net10.0 |
| demos/PuppeteerSharpPdfDemo/PuppeteerSharpPdfDemo-Local.csproj | Updated target framework to net10.0 and corresponding conditional property |
| .github/workflows/publish-docs.yml | Updated .NET SDK version to 10.0.x |
| .github/workflows/on-push-do-docs.yml | Updated .NET SDK version to 10.0.x |
| .github/workflows/dotnet.yml | Updated .NET SDK version to 10.0.x |
| .github/workflows/demo.yml | Updated .NET SDK version to 10.0.x and framework references |
| .github/workflows/PushNugetPackageToNugetOrg.yml | Updated .NET SDK version to 10.0.x |
| .github/workflows/PushNugetPackageToIntNugetOrg.yml | Updated .NET SDK version to 10.0.x |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.