Skip to content

refactor: 💡 remove usage of ember/runloop & ember-pollster#2705

Merged
lisbet-alvarez merged 10 commits intomainfrom
ICU-16533-refactor-usage-of-ember-runloop
Mar 6, 2025
Merged

refactor: 💡 remove usage of ember/runloop & ember-pollster#2705
lisbet-alvarez merged 10 commits intomainfrom
ICU-16533-refactor-usage-of-ember-runloop

Conversation

@lisbet-alvarez
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez commented Mar 4, 2025

🎟️ Jira ticket

Description

Refactor usage of ember runloop due to a new

Remove usage of ember/runloop in:

  • Form::Authenticate component
  • LoadingButton component
  • ClockTick service
  • From::Account components
    • Usage here is not needed. From old commit history it seems, like usage was attempting to fix a bug. However, that bug behaviour is not reproducible anymore.

Remove ember-pollsterusage and replace with ember-concurrency. Some usage of ember/runloop was also replaced with ember-concurrency.

NOTE: ember/runloop is still used in test files for our instance-initializers. By default ember g instance-initializer creates test files that have ember/runloop usage. For that usage, we will just disable the eslint rule. Additionally, this PR does not refactor usage in the rose::codeeditor::toolbar component since that will be replaced with HDS.

Screenshots (if appropriate)

clock-tick:

Screen.Recording.2025-03-04.at.1.37.41.PM.mov

transparent sessions:

Screen.Recording.2025-03-04.at.2.00.13.PM.mov

How to Test

  1. Validate change-password & set-password functionality for password type accounts.
  2. Validate authentication functionality (logging in to admin ui & desktop ui)
  3. Validate OIDC authentication for both admin ui & desktop ui
  4. Validate session connection using client agent.
    • Use ENABLE_MIRAGE=false yarn start:desktop & connect using bounday dev instance
    • Make sure client-agent is running by going to settings tab
    • in a terminal try ssh ssh.boundary.dev but make sure the Generated localhost ssh target with an alias target has at least one brokered credential.
    • In both mac & windows user should get a notification that when clicked takes them to established session page in DC.
    • Polling is used for retrieving the sessions from the client agent that's why this functionality needs to be tested.
  5. Validate Refresh button shows loading indicator icon when user click on it for routes such as targets & sessions.

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@vercel
Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 6:36pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 6:36pm

Copy link
Collaborator

@hashicc hashicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great so far. I want to take a closer look at ui/desktop/app/routes/scopes/scope/projects.js tomorrow but so far so good!

calcaide
calcaide previously approved these changes Mar 5, 2025
Copy link
Contributor

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific job @lisbet-alvarez !!! very well done 🙌

priya-patel04
priya-patel04 previously approved these changes Mar 5, 2025
Copy link
Collaborator

@priya-patel04 priya-patel04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Just one non-blocking comment

Co-authored-by: Zhihe Li <zhihe.li@hashicorp.com>
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! We finally got off ember-pollster and come back full circle 😆

Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! one less package to maintain ✨

@lisbet-alvarez lisbet-alvarez merged commit 29bde99 into main Mar 6, 2025
12 checks passed
@lisbet-alvarez lisbet-alvarez deleted the ICU-16533-refactor-usage-of-ember-runloop branch March 6, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants