refactor: 💡 remove usage of ember/runloop & ember-pollster#2705
Merged
lisbet-alvarez merged 10 commits intomainfrom Mar 6, 2025
Merged
refactor: 💡 remove usage of ember/runloop & ember-pollster#2705lisbet-alvarez merged 10 commits intomainfrom
lisbet-alvarez merged 10 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ithub.com/hashicorp/boundary-ui into ICU-16533-refactor-usage-of-ember-runloop
hashicc
reviewed
Mar 4, 2025
Collaborator
hashicc
left a comment
There was a problem hiding this comment.
Everything looks great so far. I want to take a closer look at ui/desktop/app/routes/scopes/scope/projects.js tomorrow but so far so good!
DhariniJeeva
reviewed
Mar 5, 2025
DhariniJeeva
reviewed
Mar 5, 2025
DhariniJeeva
reviewed
Mar 5, 2025
DhariniJeeva
reviewed
Mar 5, 2025
calcaide
previously approved these changes
Mar 5, 2025
Contributor
calcaide
left a comment
There was a problem hiding this comment.
Terrific job @lisbet-alvarez !!! very well done 🙌
priya-patel04
previously approved these changes
Mar 5, 2025
Collaborator
priya-patel04
left a comment
There was a problem hiding this comment.
Looks great!! Just one non-blocking comment
ZedLi
reviewed
Mar 5, 2025
ZedLi
reviewed
Mar 6, 2025
ZedLi
reviewed
Mar 6, 2025
Co-authored-by: Zhihe Li <zhihe.li@hashicorp.com>
1a9be2d
…ithub.com/hashicorp/boundary-ui into ICU-16533-refactor-usage-of-ember-runloop
ZedLi
approved these changes
Mar 6, 2025
Collaborator
ZedLi
left a comment
There was a problem hiding this comment.
Great work! We finally got off ember-pollster and come back full circle 😆
cameronperera
approved these changes
Mar 6, 2025
DhariniJeeva
approved these changes
Mar 6, 2025
Collaborator
DhariniJeeva
left a comment
There was a problem hiding this comment.
this looks great! one less package to maintain ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
Description
Refactor usage of ember runloop due to a new
Remove usage of ember/runloop in:
Form::AuthenticatecomponentLoadingButtoncomponentClockTickserviceFrom::AccountcomponentsRemove
ember-pollsterusage and replace withember-concurrency. Some usage ofember/runloopwas also replaced withember-concurrency.NOTE:
ember/runloopis still used in test files for our instance-initializers. By defaultember g instance-initializercreates test files that haveember/runloopusage. For that usage, we will just disable the eslint rule. Additionally, this PR does not refactor usage in the rose::codeeditor::toolbar component since that will be replaced with HDS.Screenshots (if appropriate)
clock-tick:
Screen.Recording.2025-03-04.at.1.37.41.PM.mov
transparent sessions:
Screen.Recording.2025-03-04.at.2.00.13.PM.mov
How to Test
ENABLE_MIRAGE=false yarn start:desktop& connect using bounday dev instancesettingstabssh ssh.boundary.devbut make sure theGenerated localhost ssh target with an aliastarget has at least one brokered credential.Refreshbutton shows loading indicator icon when user click on it for routes such astargets&sessions.Checklist