feat: 🎸 preferred clients section on settings page by priya-patel04 · Pull Request #3034 · hashicorp/boundary-ui

priya-patel04 · 2025-10-24T22:15:09Z

Description

Adds a new Preferred Clients section on Settings Page.

🎟️ Jira ticket

Screenshots (if appropriate)

Mac:

Screen.Recording.2025-10-27.at.12.35.57.PM.mov

None detected:

Screen.Recording.2025-10-28.at.5.24.31.PM.mov

Windows:

Screen.Recording.2025-10-27.at.1.06.55.PM.mov

None detected:

Screen.Recording.2025-10-28.at.6.05.18.PM.mov

How to Test

Navigate to Settings page and verify a new Preferred Clients section is rendered
- Mac: Windows App should be selected by default as your preferred client
- Windows: Mstc should be selected by default as your preferred client
Test updating your preferred client to None. Reopen the app and verify None selection persists.
Verfiy electron stores/update preferred client selection in the config:
- Mac: /Library/Application Support/Boundary/config.json
- Windows: \AppData\Roaming\Boundary\config.json

Checklist

I have added before and after screenshots for UI changes
I have added JSON response output for API changes
I have added steps to reproduce and test for bug fixes in the description
I have commented on my code, particularly in hard-to-understand areas
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

vercel · 2025-10-24T22:15:14Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
boundary-ui	Ready	Preview	Comment	Oct 31, 2025 9:28pm
boundary-ui-desktop	Ready	Preview	Comment	Oct 31, 2025 9:28pm

hashicc

This looks great! Would this work already with a test desktop client build? I can give that a try tomorrow if so.

My feedback is:

another test (or test assertion in the existing test) to check that the data is responding from the change event
try and assign these known set of values to constants that are exported from the best source module (maybe ui/desktop/app/services/rdp.js)

ui/desktop/tests/integration/components/settings-card/preferred-clients-test.js

addons/api/mirage/scenarios/ipc.js

priya-patel04 · 2025-10-28T15:25:23Z

This looks great! Would this work already with a test desktop client build? I can give that a try tomorrow if so.

My feedback is:

another test (or test assertion in the existing test) to check that the data is responding from the change event

try and assign these known set of values to constants that are exported from the best source module (maybe ui/desktop/app/services/rdp.js)

Yes, we can test with local DC build.

ui/desktop/app/components/settings-card/preferred-clients/index.hbs

hashicc

🚀 Looks good! Thanks for all the work on this

DhariniJeeva

looks great! 🎉

* feat: 🎸 preferred clients section on settings page * chore: 🤖 update mock ipc with new handlers * refactor: 💡 moved windows rdp protocol to const * refactor: 💡 moved rdp calls to app route * test: 💍 fixed failings tests * refactor: 💡 addressed comments * fix: 🐛 fixed failing tests * refactor: 💡 add mock rdp service calls to tests * refactor: 💡 addressed comments * test: 💍 add additional tests * refactor: 💡 fixed test failure

github-actions bot added ui addons desktop api-addon labels Oct 24, 2025

vercel bot deployed to Preview – boundary-ui-desktop October 24, 2025 23:00 View deployment

vercel bot deployed to Preview – boundary-ui October 24, 2025 23:00 View deployment

priya-patel04 self-assigned this Oct 27, 2025

priya-patel04 force-pushed the preferred_clients_section_on_settings_page branch from 550654c to 1cbed00 Compare October 27, 2025 20:44

vercel bot deployed to Preview – boundary-ui-desktop October 27, 2025 20:45 View deployment

vercel bot deployed to Preview – boundary-ui October 27, 2025 20:45 View deployment

Base automatically changed from ICU-17876-ui-desktop-ipc-implement-ipc-handlers-to-detect-and-launch-rdp-client-set-user-preferred-client to llb/rdp-client-launch October 27, 2025 21:01

priya-patel04 force-pushed the preferred_clients_section_on_settings_page branch from 1cbed00 to d129e23 Compare October 27, 2025 21:19

vercel bot deployed to Preview – boundary-ui-desktop October 27, 2025 21:21 View deployment

vercel bot deployed to Preview – boundary-ui October 27, 2025 21:21 View deployment

vercel bot deployed to Preview – boundary-ui-desktop October 27, 2025 21:32 View deployment

vercel bot deployed to Preview – boundary-ui October 27, 2025 21:32 View deployment

priya-patel04 marked this pull request as ready for review October 27, 2025 21:32

priya-patel04 requested a review from a team as a code owner October 27, 2025 21:32

hashicc requested changes Oct 27, 2025

View reviewed changes

ui/desktop/tests/integration/components/settings-card/preferred-clients-test.js Show resolved Hide resolved

addons/api/mirage/scenarios/ipc.js Show resolved Hide resolved

vercel bot deployed to Preview – boundary-ui-desktop October 27, 2025 22:26 View deployment

vercel bot deployed to Preview – boundary-ui October 27, 2025 22:27 View deployment

vercel bot deployed to Preview – boundary-ui-desktop October 28, 2025 15:42 View deployment

vercel bot deployed to Preview – boundary-ui October 28, 2025 15:42 View deployment

DhariniJeeva reviewed Oct 28, 2025

View reviewed changes

ui/desktop/app/components/settings-card/preferred-clients/index.hbs Show resolved Hide resolved

vercel bot deployed to Preview – boundary-ui-desktop October 28, 2025 22:21 View deployment

vercel bot deployed to Preview – boundary-ui October 28, 2025 22:22 View deployment

vercel bot deployed to Preview – boundary-ui-desktop October 28, 2025 22:55 View deployment

vercel bot deployed to Preview – boundary-ui October 28, 2025 22:55 View deployment

vercel bot deployed to Preview – boundary-ui October 30, 2025 19:50 View deployment

priya-patel04 requested review from DhariniJeeva and hashicc October 31, 2025 16:38

hashicc previously approved these changes Oct 31, 2025

View reviewed changes

DhariniJeeva previously approved these changes Oct 31, 2025

View reviewed changes

priya-patel04 added 11 commits October 31, 2025 16:17

feat: 🎸 preferred clients section on settings page

b5dce3f

chore: 🤖 update mock ipc with new handlers

a42b7d5

refactor: 💡 moved windows rdp protocol to const

1fc9254

refactor: 💡 moved rdp calls to app route

79a1ad6

test: 💍 fixed failings tests

4b5c7bf

refactor: 💡 addressed comments

06d5f5e

fix: 🐛 fixed failing tests

bb270e4

refactor: 💡 add mock rdp service calls to tests

117206d

refactor: 💡 addressed comments

01cf451

test: 💍 add additional tests

1a61044

refactor: 💡 fixed test failure

104a4e6

priya-patel04 dismissed stale reviews from DhariniJeeva and hashicc via 104a4e6 October 31, 2025 21:26

priya-patel04 force-pushed the preferred_clients_section_on_settings_page branch from 9f0cf22 to 104a4e6 Compare October 31, 2025 21:26

vercel bot deployed to Preview – boundary-ui-desktop October 31, 2025 21:28 View deployment

vercel bot deployed to Preview – boundary-ui October 31, 2025 21:28 View deployment

DhariniJeeva approved these changes Oct 31, 2025

View reviewed changes

priya-patel04 merged commit ef62b19 into llb/rdp-client-launch Oct 31, 2025
12 of 13 checks passed

priya-patel04 deleted the preferred_clients_section_on_settings_page branch October 31, 2025 21:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 🎸 preferred clients section on settings page#3034

feat: 🎸 preferred clients section on settings page#3034
priya-patel04 merged 11 commits intollb/rdp-client-launchfrom
preferred_clients_section_on_settings_page

priya-patel04 commented Oct 24, 2025 •

edited

Loading

Uh oh!

vercel bot commented Oct 24, 2025 •

edited

Loading

Uh oh!

hashicc left a comment

Uh oh!

Uh oh!

Uh oh!

priya-patel04 commented Oct 28, 2025

Uh oh!

Uh oh!

hashicc left a comment

Uh oh!

DhariniJeeva left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

priya-patel04 commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screenshots (if appropriate)

Mac:

None detected:

Windows:

None detected:

How to Test

Checklist

PCI review checklist

Uh oh!

vercel bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hashicc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

priya-patel04 commented Oct 28, 2025

Uh oh!

Uh oh!

hashicc left a comment

Choose a reason for hiding this comment

Uh oh!

DhariniJeeva left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

priya-patel04 commented Oct 24, 2025 •

edited

Loading

vercel bot commented Oct 24, 2025 •

edited

Loading