Skip to content

Remove Vault LDAP feature flag#3045

Merged
priya-patel04 merged 2 commits intomainfrom
remove_vault_ldap_feature_flag
Nov 5, 2025
Merged

Remove Vault LDAP feature flag#3045
priya-patel04 merged 2 commits intomainfrom
remove_vault_ldap_feature_flag

Conversation

@priya-patel04
Copy link
Collaborator

@priya-patel04 priya-patel04 commented Nov 3, 2025

Description

Removes vault-ldap-credential feature flag.

We added this flag to hide the UI work from the previous release, since this feature will be part of upcoming GA release we are now removing it.

🎟️ Jira ticket

Screenshots (if appropriate)

How to Test

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@vercel
Copy link

vercel bot commented Nov 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
boundary-ui Ready Ready Preview Comment Nov 5, 2025 7:05pm
boundary-ui-desktop Ready Ready Preview Comment Nov 5, 2025 7:05pm

@priya-patel04 priya-patel04 changed the title Removed Vault LDAP feature flag Remove Vault LDAP feature flag Nov 3, 2025
@priya-patel04 priya-patel04 marked this pull request as ready for review November 3, 2025 22:29
@priya-patel04 priya-patel04 requested a review from a team as a code owner November 3, 2025 22:29
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@priya-patel04 priya-patel04 self-assigned this Nov 5, 2025
@priya-patel04 priya-patel04 merged commit d8744e8 into main Nov 5, 2025
16 checks passed
@priya-patel04 priya-patel04 deleted the remove_vault_ldap_feature_flag branch November 5, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants