fix: 🐛 Fix filters sometimes not being displayed#3050
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hashicc
previously approved these changes
Nov 5, 2025
Collaborator
hashicc
left a comment
There was a problem hiding this comment.
It looks good, I have one partial suggestion and one comment for discussion, but nothing blocking. Thanks for looking back over the recent changes for this edge case.
65c4576 to
b8526a0
Compare
priya-patel04
approved these changes
Nov 7, 2025
Collaborator
priya-patel04
left a comment
There was a problem hiding this comment.
Tested and works as expected. Thanks for the fix!
hashicc
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One of the changes that was made in #2981 was not retrieving all resources for the dropdown filters. This had an unintended consequence when displaying the selected filters as it's possible for the selected filter to not be in the list of
allFilters.There's two main scenarios this happens (the prerequisite is having more filter options than we display which is 250):
Screenshots (if appropriate)
Before:
Screen.Recording.2025-11-04.at.2.23.52.PM.mov
After:
Screen.Recording.2025-11-04.at.2.25.09.PM.mov
How to Test
Use this cluster. Try applying different searches for the target dropdown and confirm that the filter tags always appear.
Checklist
[ ] I have added JSON response output for API changes[ ] I have addeda11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.