Skip to content

fix: 🐛 Fix filters sometimes not being displayed#3050

Merged
ZedLi merged 4 commits intomainfrom
fix-filter-display
Nov 11, 2025
Merged

fix: 🐛 Fix filters sometimes not being displayed#3050
ZedLi merged 4 commits intomainfrom
fix-filter-display

Conversation

@ZedLi
Copy link
Collaborator

@ZedLi ZedLi commented Nov 4, 2025

Description

One of the changes that was made in #2981 was not retrieving all resources for the dropdown filters. This had an unintended consequence when displaying the selected filters as it's possible for the selected filter to not be in the list of allFilters.

There's two main scenarios this happens (the prerequisite is having more filter options than we display which is 250):

  1. When filtering down the dropdown filters which means it might not be in the allFilters options. This was fixed by keeping track of all the searched options to be able to display.
  2. A user uses a query string or bookmarked a URL and goes to it directly. If the option isn't in the initial load, we won't have the actual option. In this case, I changed it to at least just display the ID instead of not showing up at all. Otherwise I'd have to load these selected options separately from the initial load which doesn't seem worth for this edge case.

Screenshots (if appropriate)

Before:

Screen.Recording.2025-11-04.at.2.23.52.PM.mov

After:

Screen.Recording.2025-11-04.at.2.25.09.PM.mov

How to Test

Use this cluster. Try applying different searches for the target dropdown and confirm that the filter tags always appear.

Checklist

  • I have added before and after screenshots for UI changes
  • [ ] I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@ZedLi ZedLi self-assigned this Nov 4, 2025
@ZedLi ZedLi requested a review from a team as a code owner November 4, 2025 20:13
@vercel
Copy link

vercel bot commented Nov 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
boundary-ui Ready Ready Preview Comment Nov 11, 2025 4:06pm
boundary-ui-desktop Ready Ready Preview Comment Nov 11, 2025 4:06pm

hashicc
hashicc previously approved these changes Nov 5, 2025
Copy link
Collaborator

@hashicc hashicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, I have one partial suggestion and one comment for discussion, but nothing blocking. Thanks for looking back over the recent changes for this edge case.

Copy link
Collaborator

@priya-patel04 priya-patel04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. Thanks for the fix!

@ZedLi ZedLi merged commit 58cc9e5 into main Nov 11, 2025
16 checks passed
@ZedLi ZedLi deleted the fix-filter-display branch November 11, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants