Skip to content

migrate ldap list wrapper fields#3162

Merged
DhariniJeeva merged 8 commits intollb/key-value-migrationfrom
migrate-ldap-list-wrapper
Feb 20, 2026
Merged

migrate ldap list wrapper fields#3162
DhariniJeeva merged 8 commits intollb/key-value-migrationfrom
migrate-ldap-list-wrapper

Conversation

@DhariniJeeva
Copy link
Collaborator

Description

This PR updates the ldap listwrapper fields to keyValue

Screenshots (if appropriate)

certificates:
after change:
Screenshot 2026-02-04 at 4 56 36 PM

Screenshot 2026-02-04 at 4 55 26 PM

account_attribute_maps
Screenshot 2026-02-04 at 5 29 28 PM

Screenshot 2026-02-04 at 5 28 50 PM

before:
certificates:

Screenshot 2026-02-04 at 4 54 24 PM Screenshot 2026-02-04 at 4 54 24 PM

account_attribute_maps
Screenshot 2026-02-04 at 5 29 40 PM

How to Test

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • [ ] I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@DhariniJeeva DhariniJeeva requested a review from a team as a code owner February 5, 2026 01:53
@DhariniJeeva DhariniJeeva self-assigned this Feb 5, 2026
@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
boundary-ui Ready Ready Preview, Comment Feb 19, 2026 11:32pm
boundary-ui-desktop Ready Ready Preview, Comment Feb 19, 2026 11:32pm

Request Review

ZedLi
ZedLi previously approved these changes Feb 11, 2026
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had one question

lisbet-alvarez
lisbet-alvarez previously approved these changes Feb 17, 2026
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the migration!

ZedLi
ZedLi previously approved these changes Feb 19, 2026
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@DhariniJeeva DhariniJeeva dismissed stale reviews from ZedLi and lisbet-alvarez February 19, 2026 23:29

The merge-base changed after approval.

@DhariniJeeva DhariniJeeva force-pushed the llb/key-value-migration branch from e975866 to 17a1b55 Compare February 19, 2026 23:29
@DhariniJeeva DhariniJeeva force-pushed the migrate-ldap-list-wrapper branch from 31786d2 to a2e1208 Compare February 19, 2026 23:31
@DhariniJeeva
Copy link
Collaborator Author

sorry for the noise but I'm closing and reopening this pr to check if that fixes the frozen state

Copy link
Collaborator

@priya-patel04 priya-patel04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@DhariniJeeva DhariniJeeva merged commit 472f215 into llb/key-value-migration Feb 20, 2026
13 checks passed
@DhariniJeeva DhariniJeeva deleted the migrate-ldap-list-wrapper branch February 20, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants