[WIP] Feature/add grpc checks

[VictorBac]

Hi guys, I am trying to add support for GRPC checks following #117

For some reason, when this line runs: https://github.com/VictorBac/consul-esm/blob/feature/add-grpc-checks/check.go#L488
my check is updated, but some information are deleted (causing following checks to be invalid)

Going from:

$ curl http://consul:8500/v1/health/node/external-node?pretty
...
            "Definition": {
                "grpc": "my-grpc-service.com:443",
                "TLSSkipVerify": true,
                "GRPCUseTLS": true,
                "interval": "10s"
            }

to:

            "Definition": {
                "TLSSkipVerify": true,
                "interval": "10s"
            }

and the GRPCUseTLS does not seem to be respected.

PS: to build this, I had too add GRPC to the check definition:
https://github.com/hashicorp/consul/pull/12108/files

Do you know what I am missing here ?

[eikenb]

Hey @VictorBac,

I don't have time to look at this very closely but have marked it for others as much as I could. If this requires consul changes you might want to ask there about if those are absolutely needed and, if so, they'd be interested in getting it added. Once you have that done then maybe come back here and update this.

[VictorBac]

Thank you @eikenb !

I am waiting for Consul to release some changes I made in their repo. Then this will work.

I'll come back when it's done.

[eikenb]

Marked this as waiting-reply to note that we're waiting on a ping about consul having been updated so this is ready for review.

[hashicorp-cla]

All committers have signed the CLA.

[drofloh]

Hi, it looks like consul supports grpc health checks for some time now, is there any plan to add grpc checks to esm?