Conversation
Compatability is attained with build tags Using tag armonmetrics or no tag at all will result in the library utilizing github.com/armon/go-metrics for metrics emission (like the library historically has done) Using tag hashicorpmetrics will result in the library utilizing the updated github.com/hashicorp/go-metrics for metrics emission.
Member
Author
|
golangci-lint seems to be having issues. It looks like it runs for too long and eventually gets killed off. Running locally doesn't produce any finding though. |
dhiaayachi
previously approved these changes
Jan 14, 2025
dhiaayachi
left a comment
dhiaayachi
left a comment
There was a problem hiding this comment.
LGTM! Left a question about linter, but nothing blocking.
dhiaayachi
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the library to using
github.com/hashicorp/go-metrics/compatinstead ofgithub.com/armon/go-metrics.Applications consuming the library can control whether metrics get emitted to either
armon/go-metricsorhashicorp/go-metricsby specifying either thearmonmetricsorhashicorpmetricsbuild tags. The default behavior is currently to preferarmon/go-metricsfor maximum backwards compatibility.Future PRs will:
hashicorp/go-metricsversion to one where the default behavior is to emit metrics usinghashicorp/go-metrics(Timeline: mid-2025)compatpackage usage with direct usage ofhashicorp/go-metrics(Timeline: end-2025)TODO:
hashicorp/go-metricsonce upstream PR is merged