Fix missing timestamps in file logging output#2092
Open
liranamrani wants to merge 1 commit intohashicorp:mainfrom
Open
Fix missing timestamps in file logging output#2092liranamrani wants to merge 1 commit intohashicorp:mainfrom
liranamrani wants to merge 1 commit intohashicorp:mainfrom
Conversation
Problem: When using file logging (log_file configuration), log messages written to files lack timestamps, while console output includes them. This inconsistency makes it difficult to correlate events and analyze logs when file logging is used. The issue occurs because the MultiWriter sends logs to both console (with timestamp wrapper) and file (without timestamp wrapper) outputs. Solution: Wrap the file writer with the same logWriter that adds timestamps to console output. This ensures both console and file logs have identical timestamp formatting while preserving all existing functionality including log rotation. Changes: - Modified logging/logging.go to wrap logFile with logWriter before adding to MultiWriter - Preserves log rotation, filtering, and all other existing features - No configuration changes required - Maintains same performance characteristics Fixes timestamp inconsistency between console and file logging output.
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Liran Amrani seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
Author
|
@pajay-rao @nitin-sachdev-29 @sreeram77 @sanikachavan5 please someone can review? |
Author
|
@hc-github-team-consul-core somebody can review??? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When using file logging (log_file configuration), log messages written to files lack timestamps, while console output includes them. This inconsistency makes it difficult to correlate events and analyze logs when file logging is used.
The issue occurs because the MultiWriter sends logs to both console (with timestamp wrapper) and file (without timestamp wrapper) outputs.
Solution:
Wrap the file writer with the same logWriter that adds timestamps to console output. This ensures both console and file logs have identical timestamp formatting while preserving all existing functionality including log rotation.
Changes:
Fixes timestamp inconsistency between console and file logging output.


before solution -
after bug fix -