[Project Solar / Phase 1 / Components] TooltipButton carbonization#3622
Open
dchyun wants to merge 8 commits intoproject-solar/phase-1-main-feature-branchfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
96d8e8d to
d7a00c7
Compare
didoo
reviewed
Feb 18, 2026
1fde917 to
788d1d2
Compare
788d1d2 to
234ca31
Compare
dchyun
commented
Feb 18, 2026
| } | ||
| } | ||
| }, | ||
| "color": { |
Contributor
Author
There was a problem hiding this comment.
[Note] There are existing tooltip variables of the format color.foreground.primary and color.surface.primary. This does not match the expected format for color variables. Additional color variables foreground.color and surface.color have been added and leveraged in the component.
For now I have left these existing color variables included, as I believe it would be a breaking change to remove them, but they could be removed in the future.
dchyun
commented
Feb 18, 2026
cbc0989 to
83e6d32
Compare
83e6d32 to
c5e15b2
Compare
c5e15b2 to
234ca31
Compare
dchyun
commented
Feb 19, 2026
e6d762c to
19e80ca
Compare
0b33772 to
fe5b5da
Compare
7401572 to
4dbc9d2
Compare
4dbc9d2 to
de5f2e4
Compare
de5f2e4 to
8816d75
Compare
8816d75 to
b6866f0
Compare
b6866f0 to
4992d47
Compare
4992d47 to
23642cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR carbonizes the
TooltipButtoncomponent and thehdsTooltipmodifier and adds component tokens for them to the tokens library.Tooltip carbonization page
🛠️ Detailed description
Summary of changes
One significant change is to the caret icon that is rendered next to the tooltip. Currently the tippjs config for the tooltip adds an svg for the caret icon. In Carbon however, the caret is rendered with css along using
clip-path: polygon(0 100%, 50% 0, 100% 100%);.To accommodate both of these use cases the SVG for the tooltip icon in HDS has been converted to be rendered through a
clip-pathusing thepath()value. A variable--token-tooltip-caret-clip-pathhas been created with aclip-pathvalue for each theme.🔗 External links
Jira ticket: HDS-5062
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.