Skip to content

Fix: Changing styles doesn't trigger showcase to rebuild#3678

Draft
shleewhite wants to merge 4 commits intomainfrom
fix/rollup-config
Draft

Fix: Changing styles doesn't trigger showcase to rebuild#3678
shleewhite wants to merge 4 commits intomainfrom
fix/rollup-config

Conversation

@shleewhite
Copy link
Contributor

@shleewhite shleewhite commented Mar 4, 2026

📌 Summary

If merged, this PR would fix an issue where changing a component Sass file does not trigger the showcase to rebuild.

🛠️ Detailed description

The custom SCSS compilation plugin was compiling SCSS files outside of Rollup's module dependency graph. Since these files weren't imported via JavaScript's import statements, Rollup had no knowledge they existed and didn't watch them for changes.

This required an update to the existing sass compilation function to explicitly register SCSS files and their dependencies with Rollup's watch system.


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Mar 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hds-showcase Ready Ready Preview Mar 4, 2026 8:37pm
hds-website Ready Ready Preview Mar 4, 2026 8:37pm

Request Review

@shleewhite shleewhite changed the title Fix/rollup config Fix: Changing styles don't trigger showcase to rebuild Mar 4, 2026
@shleewhite shleewhite changed the title Fix: Changing styles don't trigger showcase to rebuild Fix: Changing styles doesn't trigger showcase to rebuild Mar 4, 2026
@didoo didoo self-requested a review March 4, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants