feat(search_modules): Add pagination limit and filter parameters to reduce API costs#271
Open
sks wants to merge 1 commit intohashicorp:mainfrom
Open
feat(search_modules): Add pagination limit and filter parameters to reduce API costs#271sks wants to merge 1 commit intohashicorp:mainfrom
sks wants to merge 1 commit intohashicorp:mainfrom
Conversation
1436f2d to
a246b6a
Compare
Author
|
@jrhouston : PTAL, TIA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCI review checklist
Summary
This PR adds pagination and filtering parameters to the
search_modulestool to reduce API costs and improve search efficiency.Problem
Each module search was returning all matching results, leading to expensive API calls due to large response payloads.
Changes
Added the following parameters to
search_modules:limitprovideraws,google,azurerm)namespaceverifiedtrue, only return verified partner modulesImpact
current_offset, enables efficient paging through large result setsAPI Reference
These parameters are supported by the Terraform Registry API.