support importing by resource identity#1463
Merged
austinvalle merged 6 commits intomainfrom Apr 18, 2025
Merged
Conversation
1 task
d7367c3 to
458e9f6
Compare
austinvalle
approved these changes
Apr 17, 2025
Member
austinvalle
left a comment
There was a problem hiding this comment.
Great work Ansgar! I left a note about a potential helper, but that can be in a follow-up PR before stable release 👍🏻
Member
|
I'm going to merge this now and cut a beta release 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
ImportStateWithIdentitymethod toProviderwhich is used in theImportResourceStateRPC handler to optionally pass a resource identity instead of a string id. Both still exist side-by-side and will for backwards compatibility.Resources can now retrieve and set values in an identity like this to support import by identity: