TFECO-9286: add ImportStatePassthroughWithIdentity#1474
Merged
Conversation
ansgarm
changed the title
ImportStatePassthroughWithIdentity
ansgarm
changed the title
ImportStatePassthroughWithIdentityImportStatePassthroughWithIdentity
austinvalle
reviewed
Apr 22, 2025
Member
austinvalle
left a comment
austinvalle
left a comment
There was a problem hiding this comment.
Looking good! I have a suggestion for documentation and one additional test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
ImportStatePassthroughWithIdentitywhich makes it easier to implement support for import by identity if the fallbackIdattribute is part of the identity object (e.g. if it's a UUID or ARN that can just be copied as is from an attribute of the identity object into the Id string).