-
Notifications
You must be signed in to change notification settings - Fork 239
[DRAFT] Implement GenerateResourceConfig RPC and existing Terraform default logic #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SBGoods
wants to merge
14
commits into
main
Choose a base branch
from
SBGoods/generate-config-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e8a82bb
Duplicate the Core logic for default config generation
SBGoods 79e8f20
Add block to test case
SBGoods 2646f8e
Enable the `GenerateResourceConfig` server capability
SBGoods cff9024
Merge branch 'refs/heads/main' into SBGoods/generate-config-default
SBGoods 5368726
Update go.mod version to `1.24.0`
SBGoods 2e7c983
Update go.mod version to `1.24.0`
SBGoods e6d3dde
run golangci-lint run --fix
ansgarm c805480
Merge branch 'main' into SBGoods/generate-config-default
SBGoods d001e52
Apply suggestion from @ansgarm
SBGoods 6bdd5cf
Add descriptive error for `GenerateResourceConfig`
SBGoods e08324e
Merge remote-tracking branch 'origin/SBGoods/generate-config-default'…
SBGoods 6362bc6
Add test cases for nested blocks
SBGoods e747066
Add diagnostic for null current state
SBGoods be5a99b
Add changelog note
SBGoods File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| kind: NOTES | ||
| body: 'This release moves the [resource configuration generation](https://developer.hashicorp.com/terraform/language/import/generating-configuration) logic for the `-generate-config-out` flag from | ||
| Terraform Core to the SDKv2. There should be no functionality changes for resource configuration generation in this release.' | ||
| time: 2026-03-04T13:46:17.250227-05:00 | ||
| custom: | ||
| Issue: "1559" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note to us to update this before merging/releasing