New service: DeviceRegistry + new resources: azurerm_device_registry_asset and azurerm_device_registry_asset_endpoint_profile#28399
Conversation
DeviceRegistryDeviceRegistry
…d only fields per terraform requirement
…azurerm into rylo/adr-terraform
…n type since we only support one type
…ntials back to plural for golang typings in AEP, change the AEP update logic for authentication
Hi @sreallymatt thank you for the initial review. I've been addressing your feedback. We have a few questions for you and the rest of the team:
|
Hi @mryanlo, to answer your questions:
|
Hi @sreallymatt thank you for your reply. I discussed issue (1) with my team some more and, while we understand what you're saying and would prefer for the validation, we would all like to request if an exception can be made to not add the validation to both Terraform and the Azure cloud service (our API specification in ARM and our service's ResourceProvider/RP). Along with the aforementioned reasons i have provided, some of our validation is very complex and belongs in the cloud service only that cannot be done statically (e.g. validation of unique names of the DataPoints objects in property |
|
@mryanlo, after discussing this with the team we would still like to see the properties validated, at least where possible. This includes regexes for names, max/min values for integers, etc. We recognize this adds a bit of extra maintenance effort, but we do this for almost all other resources to provide a better UX. The example mentioned ( |
|
This PR is being labeled as "stale" because it has not been updated for 30 or more days. If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone. If you need some help completing this PR, please leave a comment letting us know. Thank you! |
|
Hi @sreallymatt @stephybun, sorry for the delay in response. We have been really busy with other work on our end that this became less of a priority but still needed work. Do you think you can please remove the stale label? We would like to still get back to this work soon. thanks! |
|
This PR is being labeled as "stale" because it has not been updated for 30 or more days. If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone. If you need some help completing this PR, please leave a comment letting us know. Thank you! |
This PR introduces support for the Device Registry service, comprising of:
Resources
Community Note
Description
Swagger: https://github.com/Azure/azure-rest-api-specs/tree/main/specification/deviceregistry/resource-manager/Microsoft.DeviceRegistry/stable/2024-11-01
Azure Doc: https://learn.microsoft.com/en-us/azure/iot-operations/discover-manage-assets/howto-manage-assets-remotely?tabs=cli
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
The acceptance tests for
azurerm_device_registry_assetandazurerm_device_registry_asset_endpoint_profilerequire an arc-enabled kubernetes cluster with Azure IoT Operations' service extension installed on the cluster in order to pass. Creating this cluster in the terraform acceptance tests has been successful but it takes over 45 minutes to complete. In order for the tests to run correctly, the following environment variables need to be set:If one of those variables isn't set, the tests will be skipped.
Here are the successful test results. I had to run each test one at a time because my subscription did not have enough quota to create multiple VMs. Please ensure that the Azure subscription can create multiple VMs at once. Here are the final results:
ASSET ENDPOINT PROFILE TESTS
ASSET TESTS
TESTS SKIPPED
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
DeviceRegistry- support for thedevice_registryservice [GH-00000]azurerm_device_registry_asset[GH-00000]azurerm_device_registry_asset_endpoint_profile[GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.