add support for binary_data field in config_map_v1_data

[JaylonmcShan03]

Description

Fixes #2467
This PR enhances the kubernetes_config_map_v1_data resource by introducing the binary_data field

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
test_name=TestAccKubernetesConfigMapV1Data_binaryData
--- PASS: TestAccKubernetesConfigMapV1Data_binaryData (2.89s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   3.695s
jaylon.mcshan@jaylon terraform-provider-kubernetes % 
...

Release Note

Release note for CHANGELOG:

...

References

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[alexsomesan]

It seems that data attribute is still required regardless of binary_data being set or not. IMO, it makes more sense to have an OR type of relationship. There is a use-case where a CM would only contain binary data (like ones produced by kubectl create cm 'test' --from-file=...).

However, more importantly, destroying the resource doesn't remove the binary_data items, but does remove the ones under data. We should stay consistent across the two.

[JaylonmcShan03]

@alexsomesan Regarding this portion of feedback "destroying the resource doesn't remove the binary_data items, but does remove the ones under data. We should stay consistent across the two."

Are you stating currently for the data attr we are Extracting / tracking which data entries are managed by terraform, and stripping unmanaged data entries, and for the binary_data attr that logic isn't in place. As a result, when the resource is destroyed, the binary_data items remain unchanged?

[alexsomesan]

@alexsomesan Regarding this portion of feedback "destroying the resource doesn't remove the binary_data items, but does remove the ones under data. We should stay consistent across the two."

Are you stating currently for the data attr we are Extracting / tracking which data entries are managed by terraform, and stripping unmanaged data entries, and for the binary_data attr that logic isn't in place. As a result, when the resource is destroyed, the binary_data items remain unchanged?

I just din a hands-on test and it looks like the destroy functionality performs as expected. Setting the binary_data field to empty block is equivalent to removing it from the API.
Disregard my observations about the destroy behavior.

[alexsomesan]

@JaylonmcShan03 I tested this change specifically for the observation I made about delete and it looks like it's working as expected. Setting the value of the binary_data attribute to empty or nil has an effect equivalent to delete.

In short, looks good. Let's ship it :)