Skip to content

Change all_namespaces type to set #2835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fodoj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change all_namespaces type to set #2835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kubernetes/data_source_kubernetes_all_namespaces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ func dataSourceKubernetesAllNamespaces() *schema.Resource {
ReadContext: dataSourceKubernetesAllNamespacesRead,
Schema: map[string]*schema.Schema{
"namespaces": {
Type: schema.TypeList,
Description: "List of all namespaces in a cluster.",
Type: schema.TypeSet,
Description: "Set of all namespaces in a cluster.",
Computed: true,
Elem: &schema.Schema{
Type: schema.TypeString,
Expand Down
5 changes: 2 additions & 3 deletions kubernetes/data_source_kubernetes_all_namespaces_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
func TestAccKubernetesDataSourceAllNamespaces_basic(t *testing.T) {
dataSourceName := "data.kubernetes_all_namespaces.test"
rxPosNum := regexp.MustCompile("^[1-9][0-9]*$")
nsName := regexp.MustCompile(`^[a-zA-Z][-\w]*$`)

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Expand All @@ -23,8 +22,8 @@ func TestAccKubernetesDataSourceAllNamespaces_basic(t *testing.T) {
Config: testAccKubernetesDataSourceAllNamespacesConfig_basic(),
Check: resource.ComposeAggregateTestCheckFunc(
resource.TestMatchResourceAttr(dataSourceName, "namespaces.#", rxPosNum),
resource.TestCheckResourceAttrSet(dataSourceName, "namespaces.0"),
resource.TestMatchResourceAttr(dataSourceName, "namespaces.0", nsName),
resource.TestCheckTypeSetElemAttr(dataSourceName, "namespaces.*", "default"),
resource.TestCheckTypeSetElemAttr(dataSourceName, "namespaces.*", "kube-system"),
),
},
},
Expand Down