Feat: add support sleep container lifecycle#2838
Open
akuzia wants to merge 2 commits intohashicorp:mainfrom
Open
Feat: add support sleep container lifecycle#2838akuzia wants to merge 2 commits intohashicorp:mainfrom
akuzia wants to merge 2 commits intohashicorp:mainfrom
Conversation
a90de1c to
db64727
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
none
Description
This PR aims to provide missing implementation for sleep in lifecycle hooks.
https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/#hook-handler-implementations
I'm not sure what resources need updated doc, so documentation might be changed as maintainers see fit
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
#2837
Community Note