Skip to content

validate: Add checking the backend block to the validate command#38021

Merged
SarahFrench merged 6 commits intomainfrom
sarah/validate-backend-blocks
Feb 13, 2026
Merged

validate: Add checking the backend block to the validate command#38021
SarahFrench merged 6 commits intomainfrom
sarah/validate-backend-blocks

Conversation

@SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented Dec 19, 2025

This PR updates the validate command to check the backend block.

Prior to these changes there was some checking of the backend block, achieved just by parsing the configuration. For example repeated attributes are detected before any backend-specific validation happens.

This PR introduces code that will identify:

  • If the backend type isn't recognised
  • If there are unknown attributes not in the backends schema
  • If there are missing required attributes
  • If the backend's own config validation logic returns any errors

This PR maintains the idea that validation is an offline process. Due to this we don't use the backend's Configure method at any point during validation; this would cause network traffic.

Target Release

1.15.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

…sn't match the schema.

This needs more testing, but hopefully this validation still allows validation using ENVs ok.
@SarahFrench SarahFrench force-pushed the sarah/validate-backend-blocks branch from 4438532 to 1292a4d Compare December 19, 2025 13:20
@SarahFrench SarahFrench changed the title Sarah/validate backend blocks plan: Validate backend & state_store descriptions in plan files Feb 10, 2026
@SarahFrench SarahFrench changed the title plan: Validate backend & state_store descriptions in plan files validate: Add checking backend & state_store blocks to the validate command Feb 10, 2026
@SarahFrench SarahFrench changed the title validate: Add checking backend & state_store blocks to the validate command validate: Add checking backend block to the validate command Feb 11, 2026
@SarahFrench SarahFrench changed the title validate: Add checking backend block to the validate command validate: Add checking the backend block to the validate command Feb 11, 2026
@SarahFrench SarahFrench added no-changelog-needed Add this to your PR if the change does not require a changelog entry and removed no-changelog-needed Add this to your PR if the change does not require a changelog entry labels Feb 11, 2026
@SarahFrench

This comment was marked as resolved.

@SarahFrench SarahFrench marked this pull request as ready for review February 12, 2026 10:46
@SarahFrench SarahFrench requested a review from a team as a code owner February 12, 2026 10:46
radeksimko
radeksimko previously approved these changes Feb 12, 2026
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Just very minor suggestion for the changelog entry, feel free to ignore.

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the quoting issue in my earlier suggestion!

@SarahFrench SarahFrench merged commit 694f746 into main Feb 13, 2026
7 checks passed
@SarahFrench SarahFrench deleted the sarah/validate-backend-blocks branch February 13, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants