Add annotation for an agent metrics listener#698
Draft
LS80 wants to merge 1 commit intohashicorp:mainfrom
Draft
Conversation
LS80
force-pushed
the
metrics-listener-annotation
branch
4 times, most recently
from
8301705 to
9706e38
Compare
LS80
force-pushed
the
metrics-listener-annotation
branch
from
9706e38 to
c51bed4
Compare
Contributor
Author
|
@tvoran Before I go any further with this, is it something that is likely to be accepted? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #331 by adding
vault.hashicorp.com/agent-metrics-listener-port.To enable Prometheus metrics these annotations will be needed
The
containerPortis necessary to be able to use aPodMonitorto scrape the metrics.