Fix lease duration env var in agent-injector config#778
Open
mmcgarr wants to merge 1 commit intohashicorp:mainfrom
Open
Fix lease duration env var in agent-injector config#778mmcgarr wants to merge 1 commit intohashicorp:mainfrom
mmcgarr wants to merge 1 commit intohashicorp:mainfrom
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
Author
|
Any chance of a review on this? We'd love to get this in if we can 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AGENT_INJECT_TEMPLATE_LEASE_RENEWAL_THRESHOLDenvironment variable on agent-injector pods is not being properly applied to the generated Vault agent configuration on mutated pods.Expected Behavior: When
AGENT_INJECT_TEMPLATE_LEASE_RENEWAL_THRESHOLDis set, thelease_renewal_thresholdfield should be included in thetemplate_configsection of the injected Vault agent configuration.Current Behavior: The environment variable is ignored, and
lease_renewal_thresholdis missing from the generated configuration.{ "auto_auth": { "method": { "type": "kubernetes", "mount_path": "auth/kubernetes/cluster-01", "config": { "role": "test_vault-test_vault", "token_path": "/var/run/secrets/kubernetes.io/serviceaccount/token" } }, "sink": [ { "type": "file", "config": { "path": "/home/vault/.vault-token" } } ] }, "exit_after_auth": false, "pid_file": "/home/vault/.pid", "vault": { "address": "<redacted>" }, "template": [ { "destination": "/config/mycreds", "contents": "{{ with secret \"db/test/creds/readonly\" }}{{ range $k, $v := .Data }}{{ $k }}: {{ $v }}\n{{ end }}{{ end }}", "left_delimiter": "{{", "right_delimiter": "}}" } ], "template_config": { "exit_on_retry_failure": true } }Expected config:
{ "auto_auth": { "method": { "type": "kubernetes", "mount_path": "auth/kubernetes/cluster-01", "config": { "role": "test_vault-test_vault", "token_path": "/var/run/secrets/kubernetes.io/serviceaccount/token" } }, "sink": [ { "type": "file", "config": { "path": "/home/vault/.vault-token" } } ] }, "exit_after_auth": false, "pid_file": "/home/vault/.pid", "vault": { "address": "<redacted>" }, "template": [ { "destination": "/config/mycreds", "contents": "{{ with secret \"db/test/creds/readonly\" }}{{ range $k, $v := .Data }}{{ $k }}: {{ $v }}\n{{ end }}{{ end }}", "left_delimiter": "{{", "right_delimiter": "}}" } ], "template_config": { "exit_on_retry_failure": true, "lease_renewal_threshold": 0.08 } }