Prevent tu_edpt_number() from returning an invalid endpoint number#3335
Merged
HiFiPhile merged 1 commit intohathach:masterfrom Nov 14, 2025
Merged
Prevent tu_edpt_number() from returning an invalid endpoint number#3335HiFiPhile merged 1 commit intohathach:masterfrom
HiFiPhile merged 1 commit intohathach:masterfrom
Conversation
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Collaborator
|
Thank you ! |
HiFiPhile
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
The endpoint number is 4 bits wide. The original code extracts 7 bits.
~TUSB_DIR_IN_MASK is 0x7F but we need to use 0x0F.
It is safer not to assume that bits 4..6 of bEndpointAddress are zero.
Additional context
See the bEndpointAddress description in the following link.
EndpointDescriptors